Replace cpdef variables with cdef variables. #5145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphicks
approved these changes
Jan 23, 2023
csadorf
added
improvement
|
Once CI passes I’ll need someone else to merge this. Feel free to move this to 23.04 if desired. |
Codecov ReportBase: 67.12% // Head: 67.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #5145 +/- ##
================================================
+ Coverage 67.12% 67.21% +0.08%
================================================
Files 192 192
Lines 12396 12370 -26
================================================
- Hits 8321 8314 -7
+ Misses 4075 4056 -19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/merge |
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
This PR fixes some warnings in the cuml Python build that will become errors in Cython 3. Examples follow: ``` cuml/python/cuml/decomposition/pca.pyx:334:14: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables cuml/python/cuml/decomposition/pca.pyx:587:14: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables cuml/python/cuml/decomposition/pca.pyx:683:14: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables cuml/python/cuml/decomposition/tsvd.pyx:282:14: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables cuml/python/cuml/decomposition/tsvd.pyx:398:14: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables cuml/python/cuml/decomposition/tsvd.pyx:450:14: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables cuml/python/cuml/decomposition/pca_mg.pyx:94:14: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables cuml/python/cuml/decomposition/tsvd_mg.pyx:77:14: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables cuml/python/cuml/fil/fil.pyx:82:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables cuml/python/cuml/fil/fil.pyx:83:10: cpdef variables will not be supported in Cython 3; currently they are no different from cdef variables ``` Authors: - Bradley Dice (https://github.com/bdice) Approvers: - William Hicks (https://github.com/wphicks) - Carl Simon Adorf (https://github.com/csadorf) URL: rapidsai#5145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some warnings in the cuml Python build that will become errors in Cython 3. Examples follow: